-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[async-await] Added generation of interceptors #1272
[async-await] Added generation of interceptors #1272
Conversation
Currently interceptors does not propagated to calls
|
Thanks for this! Can you regenerate the various grpc examples? |
Done. Async flag set only for echo generation, but I still launch whole generation. It added additional newline to the bottom of files. Not sure is it ok or not :) |
The extra newlines are fine 😄 |
Do you feel up to writing some tests? I'd love to see a couple of new tests, probably in |
I decided to create separate test class for async interceptors in analogy with other async tests like Waiting for further improvements suggestion 👌 |
Hello, @Lukasa! What are next steps to make further progress in this PR? Should I wait more for your review when you will have time or should I improve it somehow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops..! Thanks for catching and fixing this @Nekitosss. Would you mind running ./scripts/format.sh
to make the CI happy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @Nekitosss 🙏
Currently interceptors does not propagated to calls. Seems like it was forgotten to be implemented in this alpha implementation.